Generate the correct qualifiedRuleId for Ktlint 0.48.x #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
commented
Jan 18, 2023
| @@ -140,7 +140,7 @@ private static EditorConfigOverride createEditorConfigOverride(final List<Rule> | |||
| String[] parts = entry.getKey().substring(7).split("_", 2); | |||
| if (parts.length == 1) { | |||
| // convert ktlint_{ruleset} to {ruleset} | |||
| String qualifiedRuleId = parts[0]; | |||
| String qualifiedRuleId = parts[0] + ":"; | |||
| property = RuleExecutionEditorConfigPropertyKt.createRuleSetExecutionEditorConfigProperty(qualifiedRuleId); | |||
There was a problem hiding this comment.
...t48Dot0/java/com/diffplug/spotless/glue/ktlint/compat/KtLintCompat0Dot48Dot0AdapterTest.java
Outdated
Show resolved
Hide resolved
|
This looks great, but if it affects end-users then it needs changelog entries in plugin-gradle/CHANGES.md and plugin-maven/CHANGES.md |
|
Added. |
|
Thanks! I'll merge this after it passes CI. In the future, mild preference for not force-pushing. It's easier to review deltas than to start over, and sometimes there's something useful in an older commit that I can copy-paste into a final fixup commit before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1495.