Linting - breaking changes to internal API to prepare #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only used to annnotate errors, which will now done by the lint phase.
…ll become part of linting.
|
@jbduncan this is the same Lint PR that you reviewed earlier, but rebased and cleaned up. We're pretty close to shipping linting and configuration cache. Huzzah! |
Goooler
approved these changes
Jun 3, 2024
nedtwigg
changed the title
Goooler
approved these changes
Jun 6, 2024
|
anything I can do to help this get done? |
|
@nedtwigg really appreciate the time and work you put into this project! |
|
Thanks! 190+ contributors, I just try to keep everybody's contributions working and unblocked :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is that
DirtyStateis now the primary entry-point for using aFormatter.