Support multiple formats in Maven plugin #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
mvn-multiple-formats
branch
from
345d13d to
24ec533
Compare
thc202
reviewed
May 1, 2018
plugin-maven/README.md
Outdated
| </replaceRegex> | ||
| </format> | ||
|
|
||
| <!-- Other formats can be defined here, they will be allied in the order specified --> |
There was a problem hiding this comment.
Thanks @thc202! Fixed now
|
LGTM |
Format is a configuration element that makes it possible to apply
generic formatting steps (EndWithNewline, LicenseHeader, etc.) to
a set of files defined by custom includes and excludes. Example of
format configuration:
```
<configuration>
<format>
<includes>
<include>src/**/txt/**/*.txt</include>
</includes>
<excludes>
<exclude>src/**/txt/**/*Wrong.txt</exclude>
</excludes>
<endWithNewline/>
<trimTrailingWhitespace/>
<licenseHeader>
<content>// License Text</content>
<delimiter>start</delimiter>
</licenseHeader>
</format>
</configuration>
```
It is currently possible to only define a single `<format>` element in
plugin configuration.
This commit makes it possible to define multiple formats. Format
configuration structure remains the same but all formats should be
enclosed in `<formats>...</formats>`. Example:
```
<configuration>
<formats>
<format>...format 1 includes, excludes and steps</format>
<format>...format 2 includes, excludes and steps</format>
<format>...format 3 includes, excludes and steps</format>
</formats>
</configuration>
```
lutovich
force-pushed
the
mvn-multiple-formats
branch
from
24ec533 to
2b70d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format is a configuration element that makes it possible to apply generic formatting steps (EndWithNewline, LicenseHeader, etc.) to a set of files defined by custom includes and excludes. Example of format configuration:
It is currently possible to only define a single
<format>element in plugin configuration.This PR makes it possible to define multiple formats. Format configuration structure remains the same but all formats should be enclosed in
<formats>...</formats>. Example: