CPP extension #295
Merged
CPP extension #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents (ReadMe/Changes) have been updated.
Enhanced C support of license header delimiter rules.
# Conflicts: # CHANGES.md # README.md # plugin-maven/CHANGES.md
Superfluous integration tests of Eclipse formatter have been removed.
# Conflicts: # CHANGES.md # plugin-gradle/CHANGES.md # plugin-maven/CHANGES.md
nedtwigg
approved these changes
Sep 4, 2018
| * Hence file extension based filtering is used in line with the org.eclipse.core.contenttype.contentTypes | ||
| * defined by the CDT plugin. | ||
| */ | ||
| target(CppDefaults.FILE_FILTER.toArray()); |
| @Override | ||
| public LicenseHeaderConfig licenseHeader(String licenseHeader) { | ||
| return licenseHeader(licenseHeader, CppDefaults.DELIMITER_EXPR); | ||
| } |
thc202
reviewed
Sep 4, 2018
| File settingsFile = stepConfig.getFileLocator().locateFile(file); | ||
| eclipseConfig.setPreferences(Arrays.asList(settingsFile)); | ||
| } | ||
| System.err.println("newFormatterStep"); |
There was a problem hiding this comment.
Just noticed it's also present in #293.
|
@lutovich I would appreciate if you have a quick look at the Maven integration. |
Merged
Closed
|
Sorry for long delay, this has been shipped in |
|
Great to hear! Well done @fvgh. 🎉🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CPP extension to Gradle and Maven plugin.
Implements #232.