Wtp integration maven gradle #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Maven artifact lookup without transitives. Added test step to verify Maven artifact lookup without transitives.
nedtwigg
reviewed
Dec 22, 2018
lib-extra/src/main/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStep.java
Show resolved
Hide resolved
|
This LGTM, merge whenever you're ready @fvgh! Hope you're enjoying a great holiday! |
|
Published in 3.18.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #315, for WEB related development, no dedicated extensions for CSS, XML, ... shall be provided. The Eclipse WTP formatters shall no longer be configurable via these extensions, but become part of the generic formatter section.