Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Groovy-Eclipse release 3.2.0. Include Eclipse logging. #375

Merged
merged 3 commits into from
Mar 16, 2019

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Mar 16, 2019

Switch to Groovy-Eclipse release 3.2.0 for Eclipse 4.10.
Include Eclipse logging allowing formatter warnings/errors to be logged via SLF4J

@fvgh fvgh requested a review from nedtwigg March 16, 2019 11:05
@fvgh
Copy link
Member Author

fvgh commented Mar 16, 2019

Would be nice to have it released. Please enter a data in the change log.

This PR will not fix #357. But if it is alright with you, I will close #357 with the provision of a new default groovy-eclipse. I don't consider #357 a Spotless bug in the first place, since the extensions provide only interfaces to existing formatters. I can't help when there are bugs in the formatters.
Anyhow a few things have changed with groovy-eclipse 3.2.0, but as the main developer pointed out:

The formatter has not received much attention in the past few years

@nedtwigg
Copy link
Member

Sounds good on all fronts! Releasing...

@nedtwigg
Copy link
Member

Released!

@nedtwigg nedtwigg merged commit a968bbe into master Mar 16, 2019
@nedtwigg nedtwigg deleted the eclipse-groovy-upgrade branch March 16, 2019 18:43
@nedtwigg
Copy link
Member

Published in x.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants