Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CDT default versions to v4.11. #390

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Apr 4, 2019

spotless-eclipse-cdt changed to 4.11 which refers to CDT 7.9 for Eclipse 4.11 as provided by #389.

@nedtwigg
Copy link
Member

nedtwigg commented Apr 4, 2019

Assuming CI passes, this LGTM. The changelog for lib ought to be updated as well, but I can do that easily when I release. Shall I publish a new spotless, or should I wait for other things down the pipeline?

@fvgh
Copy link
Member Author

fvgh commented Apr 4, 2019

I am working on #292. Problems are similar to CDT clean-up. Many things expect a flawless AST. But unlike CDT, I still hope I can convince it, that it actually doesn't need to index the imports. For C++ it is different, since it really needs to know whether classes/struts exist, or whether items are for example just pre-processor defines. I think for Java it can do without. The Java code foresees anyhow hooks for adapters...

Still don't know how complex it will be and how much time I can spare.

I leave it up to you.

@fvgh fvgh merged commit 0951220 into master Apr 4, 2019
@fvgh fvgh deleted the eclipse-cdt-integration branch April 4, 2019 18:07
@nedtwigg
Copy link
Member

nedtwigg commented Apr 4, 2019

Sounds good. If anyone asks for a release, I'll be happy to make one, but until then I'll wait :)

@nedtwigg
Copy link
Member

Published in x.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants