Detect all Java source by default #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #59, by using the getAllJava() method on SourceSet instead of getJava(). The main application where this is useful is projects that do joint Java/Groovy compilation, which sometimes requires putting Java source into the Groovy directory. getAllJava() correctly picks up all of these source files. The test is a modified copy of the GoogleJavaFormatTest. The main oddity in this test is that a side-effect of the GradleIntegrationTest.write() methods is that a newline is always present at the end of the file. This means that you can't round trip a file through write()/read() and expect it to be the same. To avoid modifying that behavior, since I'm not sure how much other tests depend on it, I just re-read the groovy source after writing to ensure I could verify it wasn't changed by spotlessApply.
|
Looks great, thanks @ajoberstar! Does |
|
Yep, the test validates this as an extra safety net. |
|
Great! Just validated on my local machine. I'll merge and release as 2.4.1 today. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59, by using the getAllJava() method on SourceSet instead
of getJava(). The main application where this is useful is projects
that do joint Java/Groovy compilation, which sometimes requires putting
Java source into the Groovy directory. getAllJava() correctly picks up
all of these source files.
The test is a modified copy of the GoogleJavaFormatTest. The main oddity
in this test is that a side-effect of the GradleIntegrationTest.write()
methods is that a newline is always present at the end of the file. This
means that you can't round trip a file through write()/read() and
expect it to be the same. To avoid modifying that behavior, since I'm
not sure how much other tests depend on it, I just re-read the groovy
source after writing to ensure I could verify it wasn't changed by
spotlessApply.