Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pass filename to prettier #620

Merged
merged 12 commits into from
Jun 23, 2020
Merged

Feature/pass filename to prettier #620

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
322a292
add support for prettier to auto-detect parser
simschla Jun 20, 2020
b148f24
also test the filename-detection using a integrationTest
simschla Jun 21, 2020
fcbc706
simplify integration test in gradle and add one in maven
simschla Jun 21, 2020
cac68d3
add documentation for autodetection of parser
simschla Jun 21, 2020
08f164d
add change to "CHANGES.md" files
simschla Jun 21, 2020
36a66af
drive-by: make sure npm's correlated node is always first on path
simschla Jun 23, 2020
fbfe86c
revert opening StepHarness API to support filenames
simschla Jun 23, 2020
4ac63f9
PR feedback: forwarding to only implementation
simschla Jun 23, 2020
1953f8f
prevent illegal states by asserting non-null precondition
simschla Jun 23, 2020
40048d0
StepHarnessWIthFile had too many degrees of freedom. Testing a step …
nedtwigg Jun 23, 2020
41214ab
Most of the prettier steps don't depend on the filename, so there's n…
nedtwigg Jun 23, 2020
fb0390d
Respect "parser" the same as we respect "filepath"
nedtwigg Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/src/main/java/com/diffplug/spotless/npm/NpmProcess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ void install() {
}

Process start() {
return npm("start");
// adding --scripts-prepend-node-path=true due to https://github.com/diffplug/spotless/issues/619#issuecomment-648018679
return npm("start", "--scripts-prepend-node-path=true");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a reaction to the discussion in #619 - make sure we always use the node binary associated with the npm binary we use.

}

private void npmAwait(String... args) {
Expand Down