Add maven support for git-based copyright headers #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the last PR in this train, I'll cut releases of everything once this gets merged. |
lutovich
reviewed
Jun 29, 2020
| @@ -120,6 +121,9 @@ | |||
| @Parameter(property = "spotlessFiles") | |||
| private String filePatterns; | |||
|
|
|||
| @Parameter(property = LicenseHeaderStep.spotlessSetLicenseHeaderYearsFromGitHistory) | |||
| private String setLicenseHeaderYearsFromGitHistory; | |||
There was a problem hiding this comment.
Can this field/parameter be boolean instead of string?
I think this could simplify type signatures (boolean instead of Optional<String>) and the check in LicenseHeader
There was a problem hiding this comment.
I think there's a decent chance that we'll allow values besides "true" in the future. For example, you might want to exclude certain commits, say formatting commits, from the git history that you care about, and this is the pipe that we'll put that through.
plugin-maven/src/main/java/com/diffplug/spotless/maven/generic/LicenseHeader.java
Outdated
Show resolved
Hide resolved
|
Published in maven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
-SNAPSHOTsection of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)