Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eclipse to eclipseCdt #636

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Rename eclipse to eclipseCdt #636

merged 3 commits into from
Jul 2, 2020

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Jul 2, 2020

In the java blocks of gradle and maven, eclipse() means eclipse jdt, while in the cpp blocks, it means eclipse cdt. It's a bit inconsistent, because in the groovy block, greclipse() is distinct (as it has to be, to disambiguate from jdt version).

After the readme refactor, the docs work better if every step has a unique name, so this PR changes the name of the Eclipse CDT based formatter step to eclipseCdt in both gradle and maven. The docs were already updated to this in the above-linked readme refactor.

@nedtwigg nedtwigg merged commit 6797d93 into main Jul 2, 2020
@nedtwigg nedtwigg deleted the feat/rename-eclipse-cdt branch July 2, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant