spotlessApply no longer clobbers file permissions #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
requested changes
Aug 1, 2020
There was a problem hiding this comment.
Great, thanks! To get this merged, we need two things:
- a unit test, here is a good example. I would take your word that the code works, but without a unit test I am sure that we will break it again in the future.
- an entry in this changelog
plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskImpl.java
Show resolved
Hide resolved
…a.nio.file.attribute' are not fs agnostic; as we prefer not having fs specific conditions, we limit ourselvs to basic attribute
nedtwigg
changed the title
nedtwigg
changed the title
|
I changed the test more explicitly reproduce the original problem you found. Thanks for the find and the fix, this will get released within 48 hrs. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edited by @nedtwigg): Fixes #654.