Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sql formatter to maven #698

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Add sql formatter to maven #698

merged 3 commits into from
Sep 17, 2020

Conversation

tisoft
Copy link
Contributor

@tisoft tisoft commented Sep 16, 2020

No description provided.

@tisoft tisoft marked this pull request as draft September 16, 2020 12:40
@tisoft tisoft marked this pull request as ready for review September 16, 2020 13:10
nedtwigg
nedtwigg requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, this looks great. I requested just a few minor changes. Once they are fixed and the PR has sat for 24 hrs in case other maintainers have comment, we'll merge and release.

plugin-maven/README.md Outdated Show resolved Hide resolved
plugin-maven/src/main/java/com/diffplug/spotless/maven/sql/Sql.java Outdated Show resolved Hide resolved
plugin-maven/README.md Outdated Show resolved Hide resolved
@tisoft tisoft requested a review from nedtwigg September 16, 2020 17:35
nedtwigg
nedtwigg approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@nedtwigg nedtwigg merged commit a17fa25 into diffplug:main Sep 17, 2020
@nedtwigg
Copy link
Member

Released in plugin-maven 2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedtwigg nedtwigg nedtwigg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisoft @nedtwigg