Added missing Eclipse formatter support up to version 4.17. #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic, thanks so much! Releasing now... |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing Eclipse versions for formatter extension up to version 4.17.
The default formatter version is now 4.17, except for CDT formatter, since CDT 10.0 requires Java 11.
A default version depending on the the executing JRE version is discouraged, since this would mean that the desired formatting may change dependent on the underlying JRE version. A general approach should be taken in future how to deal with the fact that more and more formatters do not work anymore with Java 8.
This PR demonstrates that most Eclipse 4.17 formatters still work perfectly with Java 8. Hence it is recommended to close #547.
This PR makes Groovy-Eclipse 3.9.0 the new default formatter, which solves #685.