Fix spotlessFiles parameter tests

[driv]

• (,| and ) should not be escaped with \, otherwise they get
  interpreted as literals and no file matches
• On Windows paths use backslashes, so \\\\ has to be used.
  2 for java strings and 2 since this parameter is treated as a regex.

Few remarks:

• No issue for this, I just couldn't make it run check on Windows. Changes only on Tests.
• I don't have a unix machine right now to test it on.
• I'm not sure if/how it was even running for unix. .*/src/main/java/test\\(1\\|3\\).java should have been interpreted as literal.

[nedtwigg]

Hmmm... the unix tests were passing, but now they are failing. I see your point about the parens being interpreted as literal, I'm not sure why this worked before, but it did.

[nedtwigg]

I would use

spotless/lib/src/main/java/com/diffplug/spotless/FileSignature.java

Lines 112 to 115 in 5d965e7

	/** Returns true if this JVM is running on a windows machine. */
	public static boolean machineIsWin() {
	return machineIsWin;
	}

[driv]

I was 2 seconds away from pushing this change. :)

[nedtwigg]

Sorry, guess my review was sloppy. "Is the project better now?" If the answer is yes, then I try to get people's stuff merged-in ASAP - I try to err on the side of not blocking people once I'm confident that it's not making new bugs or vulnerabilities. It's not a big deal to have this duplicated. If you want to swap this out in some future PR then fine, if it stays duplicated that's fine too.

[driv]

Sure! I'll look into the this issue #710 and add it there.

[nedtwigg]

Also, needs a changelog entry in plugin-maven/CHANGES.md. Can use this PR as the link.

[driv]

Any idea what's going on with the npm one? Does it use a different java version?

[nedtwigg]

Spotless is JRE 8+

spotless/.circleci/config.yml

Lines 92 to 107 in 23f8d69

	test_npm_8:
	<< : *env_gradle
	environment:
	# java doesn't play nice with containers, it tries to hog the entire machine
	# https://circleci.com/blog/how-to-handle-java-oom-errors/
	# try the experimental JVM option
	_JAVA_OPTIONS: "-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap"
	docker:
	- image: cimg/openjdk:8.0-node
	steps:
	- checkout
	- *restore_cache_wrapper
	- *restore_cache_deps
	- run:
	name: gradlew npmTest
	command: ./gradlew npmTest --build-cache

The Path method you are using is present in JRE 11, but not in JRE 8.

[nedtwigg]

Thanks for the fix!

[driv]

Thanks for the fix!

Thanks for your support! You make it really easy for people to contribute.