-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ktfmt dropbox style in maven plugin #764
Conversation
Thanks! The GoogleJavaFormat maven step handles this situation like this: spotless/plugin-maven/src/main/java/com/diffplug/spotless/maven/java/GoogleJavaFormat.java Lines 29 to 30 in 4002aff
The gradle plugin for GJF handles it like this: spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/JavaExtension.java Lines 100 to 107 in 4002aff
And the gradle plugin for ktfmt handles it like this: spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/KotlinExtension.java Lines 111 to 114 in 4002aff
Based on these precedents, what do you think about switching to a |
The problem is that the ktfmt step expects an enum value rather then a string so we will need to convert and validate the options users can provide. Also I was trying to keep to exposure of this option the same as gradle so if I was to make this into a string I would probably end up updating gradle to take a string (and run it through the validation) So if you are happy for me to do that I can :) |
Shipped in |
This option exists in the Gradle plugin but currently does not in the maven plugin. This exposes it in a similar way to how the Gradle plugin does.