Implement Gherkin formatting plugin #928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool, thx for opening, looks like you're on the right track, lmk when you'd like more input / ready to merge. |
jamietanna
force-pushed
the
feature/gherkin
branch
from
d913ed1
to
ed08259
Compare
|
Thanks @nedtwigg - should be ready for reviews when you get a chance. (I'll need to rebuild the PR shortly - I've just pushed the dependent upstream library, but it takes ~15-20 minutes to appear in Maven Central) |
jamietanna
force-pushed
the
feature/gherkin
branch
2 times, most recently
from
9baf9ad
to
14fbe09
Compare
As part of diffplug#907, we want to be able to format our Gherkin source files automagically. To do this, we can utilise the upstream gherkin-formatter project to do the heavy lifting, and add a few test cases within this project to make sure that functionality looks correct. We're calling this a `simple` formatter as it doesn't allow much to be configured other than the indentation size in spaces.
As we've created a Gherkin formatter as part of diffplug#907, we should make it possible to use it natively in Gradle, which requires we add it as a new supported type in `SpotlessExtension`.
jamietanna
force-pushed
the
feature/gherkin
branch
from
14fbe09
to
6f0a35c
Compare
|
Moving to a draft because there's a change that I'd prefer to be in the upstream library before this should be widely usable |
8 tasks
|
Just FYI, if you'd like to remove the reflection code, you could use the approach in #1012 if you'd like. Happy to merge either way. |
Merged
|
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #907.