-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes dependency on Java check configurable #95
Conversation
The "check" task isn't java-specific, it's meant to be general purpose. Rather than living in "JavaExtension", the flag should live in "SpotlessExtension", and it should apply to all formatting tasks. I think "runSpotlessCheckOnCheck" is unhelpful for users who haven't dug into the code. Maybe "enforceCheck"? Also, do you mind squashing these into one commit for easier review? Thanks! |
c116941
to
0711a77
Compare
@jbduncan I don't think the rename is needed. I have a project where I'm printing the property just for testing purposes and I'm accessing as follows
|
General types should be Thanks for a good PR :) |
Thanks @nedtwigg. Please let me know if you are planning to do a release soon so I can uptake this in my projects. Or alternatively, do you have a Maven repository where this is in snapshot form? |
It's available in 3.2.0-SNAPSHOT here, and we'll release later today: https://oss.sonatype.org/content/repositories/snapshots/com/diffplug/spotless/spotless-plugin-gradle/ |
Thanks! |
As discussed in #79, though not strictly related to that issue, we can relax the dependency from Java's check task to spotlessCheck.
For backwards compatibility, and to respect @nedtwigg 's opinion on the philosophy of this project, the default is to add the dependency.