Consolidate skip behavior (take two) #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it needs a |
lutovich
approved these changes
Oct 20, 2021
plugin-maven/src/main/java/com/diffplug/spotless/maven/AbstractSpotlessMojo.java
Outdated
Show resolved
Hide resolved
lutovich
approved these changes
Oct 20, 2021
|
Thanks to you both for your patience with me :) Let me know if you'd like it to get released now, but I assume it's okay to wait for some other features to pile on to the release train first. |
|
@nedtwigg compared to trying to get traction on the bugs and PRs I've opened against Elasticsearch and Flink this all happened at lightning speed so thanks, one less thing I have to keep track of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #969 for the first version of this fix
This is a second attempt that preserves the distinction between
spotless.apply.skipandspotless.check.skip