Resolve dependencies from "project" repositories, not buildscript #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the root project.
… to 6.1 but didn't note it in the changelog.
…e new kotlin plugin.
This reverts commit 81978b3.
nedtwigg
changed the title
This was referenced Nov 7, 2021
|
This change looks good to me. And if it solves the two mentioned issues (which would allow |
This was referenced Nov 8, 2021
nedtwigg
changed the title
|
Released in plugin-gradle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, many projects required
buildscript { repositories { mavenCentral() }}at the top of their root project, because Spotless resolved its dependencies using the buildscript repositories. This concept is mostly dead now (e.g. #740, #941). After this PR we now resolve dependencies using the normal project repositories of the root project.Follow-up work
There is a lot of demand for full configuration-cache support (#644). In this comment I explain a possible way forward. I'm exploring that right now, and I expect to update this PR based on what I find. If it takes too long, we can merge and release this PR as-is.