Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuration cache within a single daemon (JvmLocalCache) #986

Merged
merged 15 commits into from
Nov 9, 2021
Merged

Support configuration cache within a single daemon (JvmLocalCache) #986

merged 15 commits into from
Nov 9, 2021

Commits on Nov 8, 2021

  1. Create a spotlessSetup plugin, and repurpose `RegisterDependenciesT… 

    …ask` so that it stores a value which can be injected into the SpotlessTaskService on every build.
    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    9c03d4d View commit details
    Browse the repository at this point in the history

  2. It's easier to make GitRatchet cache-friendly if setupRatchet alway… 

    …s gets called, so that we can differentiate `not-hydrated` from `ratchet inactive`
    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    0316ef7 View commit details
    Browse the repository at this point in the history

  3. Introduce a class to store all the transient fields of a task.

    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    b384f5a View commit details
    Browse the repository at this point in the history

  4. Whenever a task runs, we store its transient state.

    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    b92b256 View commit details
    Browse the repository at this point in the history

  5. And we guard every transient getter of SpotlessTask with `hydrateIfNu… 

    …ll`.
    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    00646fe View commit details
    Browse the repository at this point in the history

  6. Consolidate our hydrate exceptions into one place.

    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    1cd0de0 View commit details
    Browse the repository at this point in the history

  7. And a test to demonstrate that it works.

    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    5f4a0b5 View commit details
    Browse the repository at this point in the history

  8. It works for git ratchet too. 

    Note: we removed the test for an empty project folder (deleted L186-187) because it triggered a bug in Gradle gradle/gradle#18897. Hard to imagine how it could actually happen in the wild, so no sense banging our head against it.
    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    642ac61 View commit details
    Browse the repository at this point in the history

  9. enableConfigCacheDaemonLocal is too long, jvmLocalCache is better.

    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    2768996 View commit details
    Browse the repository at this point in the history

  10. Change our error messages to reference the workaround, and also to po… 

    …int to our explanation issue.
    @nedtwigg
    nedtwigg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    3307b82 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Migrate from our one-off to the design we'd like Gradle to adopt.

    @nedtwigg
    nedtwigg committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    166ab79 View commit details
    Browse the repository at this point in the history

  2. It's hard to turn off JvmLocalCache, and there isn't a good reason to… 

    …, so we don't have any need for the SpotlessSetup plugin anymore.
    @nedtwigg
    nedtwigg committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ee5aaf8 View commit details
    Browse the repository at this point in the history

  3. Make the diff a little smaller.

    @nedtwigg
    nedtwigg committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    cfc8291 View commit details
    Browse the repository at this point in the history

  4. Better names for JvmLocalCache, and initial values were a bad idea.

    @nedtwigg
    nedtwigg committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ba49043 View commit details
    Browse the repository at this point in the history

  5. Update changelog.

    @nedtwigg
    nedtwigg committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ca3560e View commit details
    Browse the repository at this point in the history