chore: update stylesheets and remove posix #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmyers13
commented
Sep 23, 2025
| "metadata": { | ||
| "kernelspec": { | ||
| "display_name": "Python 3", | ||
| "display_name": "cmi", |
There was a problem hiding this comment.
This looks like metadata from the env I ran it in (my env is called "cmi").
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 81.75% 81.73% -0.02%
==========================================
Files 11 11
Lines 1211 1210 -1
==========================================
- Hits 990 989 -1
Misses 221 221
🚀 New features to boost your workflow:
|
|
@sbillinge ready for review. should be quick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9
All places where plots are generated are up to date with bg_stylesheets
Somehow the posix method from the tests PR slipped through. I just double checked the tests PR that got merged and it got included: https://github.com/diffpy/diffpy.cmi/pull/45/files. Not sure how that happened, I thought I deleted it. Anyways, this removes it.
Also there was a debugging print statement that I accidentally left in there thats removed here. oops!