Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

Copied this example from https://github.com/diffpy/add2019-diffpy-cmi/tree/master.

I also tested to see how it appears when I run cmi example list and it behaves as expected:
image

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.73%. Comparing base (656e3f3) to head (751df3c).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   81.75%   81.73%   -0.02%     
==========================================
  Files          11       11              
  Lines        1211     1210       -1     
==========================================
- Hits          990      989       -1     
  Misses        221      221              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review. Adding new exampel

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this example as a python module also so it will run in tests?

@cadenmyers13
Copy link
Contributor Author

@sbillinge copied the code into a python module. This should be captured in the test

@sbillinge
Copy link
Contributor

isn't that pretty! I will merge when tests pass (since they are actually testing a new example).

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for merge. codecov is failing but it looks like maybe its from the notebook not being covered? idk 🥴

@sbillinge sbillinge merged commit 61f353e into diffpy:main Sep 26, 2025
4 of 5 checks passed
@cadenmyers13 cadenmyers13 deleted the core-ex branch September 26, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants