skpkg: change project files in distanceprinter to better match skpkg workflow files #23
Conversation
|
@sbillinge ready for review. |
| This package is not designed to be installed independently. To get started, please visit | ||
| https://www.diffpy.org/products/xPDFsuite.html for more information about the xpdfsuite package and | ||
| https://www.diffpy.org/products/xPDFsuite.html for more information about the xpdfsuite package and | ||
| download the package together with ``diffpy.xpdfsuite``. |
There was a problem hiding this comment.
By the way, should I change what is currently written to something else? Once we make distanceprinter public and and available on PyPI/CF, etc, it can presumably be installed independently from xpdfsuite. What should I say in that case?
(Note, this section in srxconfutils will also have to be changed if we do decide to make changes here)
There was a problem hiding this comment.
ah, yes, good point. Let's leave the text saying that it comes with xpdfsuite, but we will also want something describing how it could be used independently. I never tried this so I am not sure what it does if you try and run it independently. Maybe you could play around with it for a while to see?
There was a problem hiding this comment.
I'm not exactly sure how this package can be ran, but I did see that distanceprinter.py requires
strufile, atomi, atomj, lb, ub, complete, filename
as CLI arguments
| prohibited. If you don’t know whether or not your anticipated use is under | ||
| a license, you must contact Prof. Simon Billinge at sb2896@columbia.edu. | ||
| Use of this software without a license is prohibited. | ||
| BSD 3-Clause License |
There was a problem hiding this comment.
license text is fine but please change everywhere (global replace) LICENSENOTICE to LICENSE (and look for txt -> rst changes too in this regard)
|
@sbillinge ready for review |
2 participants
No description provided.