Skip to content

Conversation

@cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Oct 27, 2024

See comment on other PR

@sbillinge
Copy link
Contributor

@cadenmyers13 please see the discussion on the other PR. I will close this for now as I am guessing it is not what we want.

@sbillinge sbillinge closed this Oct 28, 2024
@cadenmyers13
Copy link
Contributor Author

@cadenmyers13 please see the discussion on the other PR. I will close this for now as I am guessing it is not what we want.

@sbillinge In reference to your message here, is this PR what you want? The edits made here surpress the Runtimewarnings.

@sbillinge
Copy link
Contributor

@cadenmyers13 please see the discussion on the other PR. I will close this for now as I am guessing it is not what we want.

@sbillinge In reference to your message here, is this PR what you want? The edits made here surpress the Runtimewarnings.

yes, if this works, this is exactly what I am after.... code is good, tests are testing what we want, code generates appropriate warnings, but they don't appear as warnings in the tests.....perfect if this actually does suppress them (I guess you tested that?)

@sbillinge sbillinge reopened this Oct 30, 2024
@cadenmyers13
Copy link
Contributor Author

@cadenmyers13 please see the discussion on the other PR. I will close this for now as I am guessing it is not what we want.

@sbillinge In reference to your message here, is this PR what you want? The edits made here surpress the Runtimewarnings.

yes, if this works, this is exactly what I am after.... code is good, tests are testing what we want, code generates appropriate warnings, but they don't appear as warnings in the tests.....perfect if this actually does suppress them (I guess you tested that?)

Yes, running pytest I did not get the RuntimeWarning

@bobleesj
Copy link
Contributor

@cadenmyers13 just a thought, do we want to a bit documentation/comments in the test code itself why those warnings are being surpassed for future members?

@sbillinge sbillinge merged commit 37fc5e5 into diffpy:main Oct 30, 2024
3 checks passed
@sbillinge
Copy link
Contributor

Nice @cadenmyers13 ! Code is now just a little bit better.

@cadenmyers13
Copy link
Contributor Author

@cadenmyers13 just a thought, do we want to a bit documentation/comments in the test code itself why those warnings are being surpassed for future members?

Good idea. I can add that

@cadenmyers13 cadenmyers13 deleted the tests branch October 30, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants