- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7
skpkg: Migration #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skpkg: Migration #87
Conversation
skpkg (redo): setup CI after migrating tests, src, requirements, and .github folder
skpkg: rename variable cutted as cutoff_applied
skpkg: migrate documentation, add news
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          166      166           
  Misses         11       11           
 🚀 New features to boost your workflow:
 | 
| this PR looks a bit dirty (many commits with many merges and things). Was this build from a fully sync'ed main? I think these changes probably should only be on one or two commits? | 
| @sbillinge yeah, these are commits from the 3 skpkg PRs that we merged into  | 
| Oh, I see. This is the merge from migration into main. Sorry, my bad. It's ok there are many commits in this case. | 
The doc built, and I ran fourigui with a test data. Everything looks good so I think we're good to go!