changed output directory and wavelength tests to use get_args

[yucongalicechen]

No description provided.

[sbillinge]

this looks good . Please can you see inline comments

[sbillinge]

We are after the full input with -- in front, not the abbreviated one with a single dash

…

On Mon, May 6, 2024, 4:47 PM Yucong (Alice) Chen ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/diffpy/labpdfproc/tests/test_tools.py <#49 (comment)> : > from diffpy.labpdfproc.tools import known_sources, set_output_directory, set_wavelength params1 = [ - ([None], ["."]), - (["."], ["."]), - (["new_dir"], ["new_dir"]), - (["existing_dir"], ["existing_dir"]), + ([], ["."]), + (["-o", "."], ["."]), I think the string here needs to be one of the arguments for user to specify? For example user specifies -o instead of output_directory. If we put output_directory it will cause an error saying it's not one of the arguments. Not sure if what I say here completely makes sense. — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAOWUNPYHEAMEDOEZM3ZETZA7T5BAVCNFSM6AAAAABHJULLDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBRGY2DSMZSGI> . You are receiving this because you commented.Message ID: <diffpy/diffpy. ***@***.***>

[sbillinge]

This looks great. If you could just resolve the conflict and fix the one inline comment I can merge.