Use non-resuable GitHub CI to run Python 3.10, 3.11, 3.12 tests #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
bobleesj
commented
Nov 27, 2024
There was a problem hiding this comment.
Once this PR is merged, I can create issues to use reusable workflow for the following .yml files - after we figure out py 3.13 windows build problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 6 6
Lines 1261 1261
=======================================
Hits 1248 1248
Misses 13 13 |
|
Ready for review @sbillinge - this PR will address the following: 
|
Okay, CI passing now, as expected. |
|
@bobleesj a general comment, shouldn't we be dropping the legacy python version support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are having Python 3.13 windows build problem, support 3.10, 3.11, 3.12 again.