Skip to content

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Jan 8, 2025

closes #113

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (46c5082) to head (3d40d9b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           6        6           
  Lines        1261     1261           
=======================================
  Hits         1248     1248           
  Misses         13       13           
Files with missing lines Coverage Δ
tests/test_exceptions.py 99.80% <ø> (ø)
tests/test_pdffit.py 99.76% <ø> (ø)
tests/test_phase_fractions.py 98.70% <ø> (ø)
tests/test_shape_factors.py 99.53% <ø> (ø)
tests/test_version.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@sbillinge
Copy link
Contributor

super. I am afraid this became conflicted. But it looks good to merge if you can resolve the conflict.

I added "closes" to the initial comment, but if this doesn't "close" #113 please change the comment to smething more informatoinl such as "addresses" or "handles the prettier part of #113" or whatever the situation is.

This reverts commit b1e6944.
@Tieqiong
Copy link
Contributor Author

Tieqiong commented Jan 8, 2025

@sbillinge This address the action part of #113. We can close it I think

@sbillinge sbillinge merged commit 24fb526 into diffpy:main Jan 8, 2025
5 checks passed
@Tieqiong Tieqiong deleted the pcmt branch January 12, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: skpackage v0.1.0: modify .github and .pre-commit-config.yaml. Follow new practices for writing commit/issue and news.rst file
2 participants