-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add option to skip copyright header #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 98.96% 98.97%
=======================================
Files 6 6
Lines 1261 1268 +7
=======================================
+ Hits 1248 1255 +7
Misses 13 13
|
I believe this is basically what I had in mind! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Please can you update docstrings and documentation and add a news and I can merge.
@Tieqiong this could also use a little test for the |
@sbillinge please check, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I reviewed this but somehow didn't post the review.....
closes #25
@8bitsam @matthewcarbone May I ask if this solve the problem? A use case to skip the copyright:
@sbillinge please review, thanks!