Skip to content

Conversation

Tieqiong
Copy link
Contributor

closes #25

@8bitsam @matthewcarbone May I ask if this solve the problem? A use case to skip the copyright:

P = PdfFit(intro=False)

@sbillinge please review, thanks!

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (24fb526) to head (b3b654f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   98.96%   98.97%           
=======================================
  Files           6        6           
  Lines        1261     1268    +7     
=======================================
+ Hits         1248     1255    +7     
  Misses         13       13           
Files with missing lines Coverage Δ
tests/test_pdffit.py 99.76% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@matthewcarbone
Copy link

I believe this is basically what I had in mind!

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Please can you update docstrings and documentation and add a news and I can merge.

@sbillinge
Copy link
Contributor

@Tieqiong this could also use a little test for the intro=false case.

@Tieqiong
Copy link
Contributor Author

@sbillinge please check, thanks

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I reviewed this but somehow didn't post the review.....

@sbillinge sbillinge merged commit 44792a2 into diffpy:main Jan 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise the way outputs are printed to the console
3 participants