perf: improve gsl linking #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 6 6
Lines 1261 1261
=======================================
Hits 1248 1248
Misses 13 13 |
sbillinge
approved these changes
Jan 12, 2025
| gslcfgpaths = [Path(p) / "gsl-config" for p in ([MYDIR] + os.environ["PATH"].split(os.pathsep))] | ||
| gslcfgpaths = [p for p in gslcfgpaths if p.is_file()] | ||
| """ | ||
| Determine the GSL include and library directories by trying in order: |
There was a problem hiding this comment.
This is much much clearer, thanks for doing this @Tieqiong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #117 there exists a cached runner but it seems not related to the current error. This PR will actually fix the problem (not the cache)
@sbillinge please check, thanks
Inspired from the
setup.pywrote yesterday forsrreal, decide to do a deep cleaning on this one too. It should also fix the current weird failing CI matrix test