Skip to content

Conversation

bobleesj
Copy link
Contributor

  • Use conftest.py
  • rename test file names from TestPdfFit.py to test_pdffit.py, etc.

@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 22, 2024

Warning also removed: Based on forked CI result: https://github.com/bobleesj/diffpy.pdffit2/actions/runs/10983571527/job/30493096104

From:

=============================== warnings summary ===============================
../../../../../usr/share/miniconda/envs/test/lib/python3.12/site-packages/diffpy/structure/version.py:29
  /usr/share/miniconda/envs/test/lib/python3.12/site-packages/diffpy/structure/version.py:29: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    from pkg_resources import resource_filename

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 112 passed, 1 warning in 0.66s ========================

to

tests/test_exceptions.py ............................................... [ 41%]
.........................                                                [ 64%]
tests/test_pdffit.py ..............................                      [ 91%]
tests/test_phase_fractions.py ..                                         [ 92%]
tests/test_shape_factors.py ........                                     [100%]

============================= 112 passed in 0.60s ==============================

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

I think we need a news

@sbillinge sbillinge merged commit b19c917 into diffpy:main Sep 23, 2024
2 checks passed
@bobleesj bobleesj deleted the tests-dir branch September 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants