Skip to content

added tag-check for desired format #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

added tag-check for desired format #104

wants to merge 1 commit into from

Conversation

@alisnwu
Copy link
Contributor

@alisnwu alisnwu commented Oct 17, 2024

closes #103

@github-actions
Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@alisnwu alisnwu closed this Oct 17, 2024
@alisnwu alisnwu deleted the tag-check branch October 17, 2024 20:09
sbillinge
sbillinge reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a testing, but one comment is that the numberals are not limited to the range 0-9 so we may want to replace [0,9] with something like \d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbillinge sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add regex/pattern matching for tag used for release

2 participants

@alisnwu @sbillinge