Skip to content

Conversation

@alisnwu
Copy link
Contributor

@alisnwu alisnwu commented Oct 17, 2024

closes #103

@alisnwu
Copy link
Contributor Author

alisnwu commented Oct 17, 2024

@sbillinge Ready for review

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this on another closed branch, but numerals are not limited to the range 0-9 so we may want to replace [0,9] everywhere with something like \d.

@alisnwu
Copy link
Contributor Author

alisnwu commented Oct 19, 2024

The + behind each 0-9 allows for multiple digits, so 10.10.133 would also be accepted by the .yml

@sbillinge
Copy link
Contributor

The + behind each 0-9 allows for multiple digits, so 10.10.133 would also be accepted by the .yml

ah, thanks.

@sbillinge sbillinge merged commit e64a164 into diffpy:main Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add regex/pattern matching for tag used for release

2 participants