Skip to content

Create codecov.yml for coverage testing (Do not merge) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Create codecov.yml for coverage testing (Do not merge) #86

wants to merge 7 commits into from

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Sep 17, 2024

Addressing #85

Copy link

Warning! No news item is found for this PR. If this is an user facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (b5a0366) to head (e41e218).

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #86       +/-   ##
==========================================
+ Coverage   0.00%   93.38%   +93.38%     
==========================================
  Files          9        6        -3     
  Lines        240      136      -104     
==========================================
+ Hits           0      127      +127     
+ Misses       240        9      -231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tieqiong
Copy link

Tieqiong commented Sep 17, 2024

Well this is not good (still having 0%). We might have to look into .coveragerc and codecov.yml

@bobleesj
Copy link
Contributor Author

This is for testing to initiate GitHub Actions.

I think I've figured out the problem.

@bobleesj bobleesj changed the title Create codecov.yml for coverage testing Create codecov.yml for coverage testing (Do not merge) Sep 17, 2024
@bobleesj
Copy link
Contributor Author

@Tieqiong We shall use pytest-cov instead of using coverage to run pytest. The previous error occurred because the tests folder has been moved to the top directory level and coverage isn't able to import diffpy.snmf due to the namespace.

@bobleesj
Copy link
Contributor Author

Screenshot 2024-09-16 at 10 46 51 PM

It runs now. Will chat more tomorrow.

@bobleesj
Copy link
Contributor Author

Closing this PR since the new workflow indeeds works for diffpy.utils's codecov.

@bobleesj bobleesj closed this Sep 18, 2024
@bobleesj bobleesj deleted the patch-1 branch September 18, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants