Skip to content

Conversation

ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Aug 6, 2025

What problem does this PR address

Fix failed examples as mentioned in #119 (comment)

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.60%. Comparing base (de32312) to head (65cb6de).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files          25       25           
  Lines        3171     3171           
=======================================
  Hits         2112     2112           
  Misses       1059     1059           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

@ycexiao ycexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge, it's ready for review.

@@ -91,8 +91,8 @@ def makeRecipe():

# Load data and add it to the profile. It is our responsibility to get our
# data into the profile.
xydy = numpy.array(map(float, data.split()), dtype=float).reshape(-1, 3)
x, y, dy = numpy.hsplit(xydy, 3)
xydy = numpy.array(data.split(), dtype=float).reshape(-1, 3)
Copy link
Contributor Author

@ycexiao ycexiao Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data is something like

data = """\
015.0 0.00334 0.00013
050.0 0.00508 0.00022
...
500.0 0.03946 0.00250
"""

Unpacking the data in this specific way is only applicable in this example.

@ycexiao ycexiao marked this pull request as ready for review August 6, 2025 19:59
@sbillinge sbillinge merged commit 0a3933d into diffpy:main Aug 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants