-
Notifications
You must be signed in to change notification settings - Fork 1
skpkg: list dependencies in requirements folder #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zmx27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
| traits | ||
| traitsui | ||
| diffpy.srxplanar | ||
| configparser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fabio, pyfai, etc should probably be here too
requirements/conda.txt
Outdated
| fabio | ||
| pyfai | ||
| matplotlib | ||
| pyface No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that some packages like chaco is not on conda forge, but could you look into the other packages listed in pip.txt? Ideally we want both of these files to be very similar to each other
|
@zmx27 Ready for review |
zmx27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked that the files listed in pip.txt but not in conda.txt don't have a conda equivalent in conda forge? Also, I think you're missing matplotlib in pip.txt
@zmx27 I have checked for each dependency one by one and ensure it is correct. By the way I have added |
|
This seems to have failed pre-commit @stevenhua0320 . It was an auto-update so you will have to pull your origin and merge it into your local before pushing again. |
@zmx27 Ready for review