Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

@zmx27 Ready for review

Copy link
Collaborator

@zmx27 zmx27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

traits
traitsui
diffpy.srxplanar
configparser
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabio, pyfai, etc should probably be here too

fabio
pyfai
matplotlib
pyface No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that some packages like chaco is not on conda forge, but could you look into the other packages listed in pip.txt? Ideally we want both of these files to be very similar to each other

@stevenhua0320
Copy link
Contributor Author

@zmx27 Ready for review

Copy link
Collaborator

@zmx27 zmx27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that the files listed in pip.txt but not in conda.txt don't have a conda equivalent in conda forge? Also, I think you're missing matplotlib in pip.txt

@stevenhua0320
Copy link
Contributor Author

Have you checked that the files listed in pip.txt but not in conda.txt don't have a conda equivalent in conda forge? Also, I think you're missing matplotlib in pip.txt

@zmx27 I have checked for each dependency one by one and ensure it is correct. By the way I have added matplotlib into the dependency in pip.txt. See the new commit.

@sbillinge
Copy link
Contributor

This seems to have failed pre-commit @stevenhua0320 . It was an auto-update so you will have to pull your origin and merge it into your local before pushing again.

@sbillinge sbillinge merged commit f324598 into diffpy:migration Oct 7, 2025
1 check failed
@sbillinge sbillinge deleted the setup-CI-4 branch October 7, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants