Numpy >=2.0 support with depreciation warning removed #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Sep 22, 2024
bobleesj
commented
Sep 22, 2024
bobleesj
commented
Sep 22, 2024
sbillinge
approved these changes
Sep 23, 2024
|
@bobleesj I think we need a news |
|
Ready for review with news added! |
|
For what it's worth, I pulled v3.2.2rc0 and NumPy v2 locally for orix and our test suite ran without problems (after fixing a v2-incompatibility of our own). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
Please see inline comments.