Reorganized test files to match src folder structure #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 99.17% 99.17% -0.01%
==========================================
Files 7 7
Lines 243 242 -1
==========================================
- Hits 241 240 -1
Misses 2 2
|
sbillinge
reviewed
Nov 13, 2024
tests/conftest.py
Outdated
|
|
||
| def _load(filename): | ||
| return "tests/testdata/" + filename | ||
| return str(base_path / filename) |
There was a problem hiding this comment.
is there a reason you return a string and not the Path object?
There was a problem hiding this comment.
I was trying to match the original return of strings but the Path object also works, will edit to just return the Path object
There was a problem hiding this comment.
This work is exactly what Path is designed for.
|
|
||
| def test_load_multiple(tmp_path, datafile): | ||
| # Load test data | ||
| targetjson = datafile("targetjson.json") | ||
| generatedjson = tmp_path / "generated_serialization.json" | ||
|
|
||
| tlm_list = os.listdir(os.path.join(tests_dir, "testdata", "dbload")) | ||
| tlm_list.sort() | ||
| dbload_dir = os.path.dirname(datafile("dbload/e1.gr")) |
There was a problem hiding this comment.
then do these two lines using pathlib and pathlib globing?
There was a problem hiding this comment.
Yep, will use pathlib for both parts
| generated_data = None | ||
| for hfname in tlm_list: | ||
| # gather data using loadData | ||
| headerfile = os.path.normpath(os.path.join(tests_dir, "testdata", "dbload", hfname)) | ||
| headerfile = os.path.join(dbload_dir, hfname) |
added 2 commits
November 12, 2024 21:25
|
@sbillinge Ready for review |
|
Much nicer, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #160
@sbillinge pytest passed, ready for review