add d_to_tth, tth_to_d #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yucongalicechen
commented
Dec 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 94.37% 96.49% +2.11%
==========================================
Files 8 8
Lines 320 342 +22
==========================================
+ Hits 302 330 +28
+ Misses 18 12 -6
|
|
@yucongalicechen this looks good, but I made a small tweak to an error message in the other PR so this is now conflicted. Please can you merge main, keeping the new message, to resolve this, and then I can merge it. |
yucongalicechen
commented
Dec 7, 2024
| [np.array([5 * np.pi, 4 * np.pi, 3 * np.pi, 2 * np.pi, np.pi, 0])], | ||
| np.array([0.4, 0.5, 0.66667, 1, 2, np.inf]), | ||
| [np.array([0, 1 * np.pi, 2 * np.pi, 3 * np.pi, 4 * np.pi, 5 * np.pi])], | ||
| np.array([np.inf, 2, 1, 0.66667, 0.5, 0.4]), |
There was a problem hiding this comment.
small edit so that we have an increasing qarray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #175
@sbillinge ready for review