Skip to content

Simon tweaks to DO examples #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Simon tweaks to DO examples #252

merged 2 commits into from
Dec 18, 2024

Conversation

sbillinge
Copy link
Contributor

@sbillinge sbillinge commented Dec 18, 2024

@yucongalicechen @alisnwu please can you review and see if the instructions make sense after my hacks. Also, please check that they build ok.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (641a107) to head (6ee7a95).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          380       380           
=========================================
  Hits           380       380           

@sbillinge
Copy link
Contributor Author

@yucongalicechen @alisnwu I will go ahead and merge this as it is easier for you to review the docs by building them and looking at the built docs. Please make new PRs with fixes.

@sbillinge sbillinge merged commit 2bc765f into diffpy:main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant