Skip to content

Remove 6 pytest warnings with capturing wavelength warnings #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Dec 20, 2024

Making smaller PRs since @sbillinge is on the road.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27f433d) to head (5080163).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          380       386    +6     
=========================================
+ Hits           380       386    +6     
Files with missing lines Coverage Δ
tests/test_transforms.py 100.00% <100.00%> (ø)

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is good here so I will merge to keep things going, but please see the comments on the news.

@@ -0,0 +1,23 @@
**Added:**

* No news added
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use something like:

* no news added: intercepting warnings generated by tests on purpose not needed by users or devs.

With that said, I think this probably would be good to hvae a news.....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup noted. There are other remaining warnings, etc. I will include that news item

@sbillinge sbillinge merged commit d5d3bf7 into diffpy:main Dec 20, 2024
5 checks passed
@bobleesj bobleesj deleted the pytest-warnings-oths branch December 20, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants