Skip to content

Catch wavelength=none warnings in DiffractionObject #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

bobleesj
Copy link
Contributor

Done..

======= 100 passed, 9 warnings in 0.20s ==========

9 warnings left - all coming from divide by zero error. I will fix this once #260 is merged.

@bobleesj
Copy link
Contributor Author

ready for review @sbillinge

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d5d3bf7) to head (13b42b5).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #261   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          384       388    +4     
=========================================
+ Hits           384       388    +4     
Files with missing lines Coverage Δ
tests/test_diffraction_objects.py 100.00% <100.00%> (ø)
tests/test_transforms.py 100.00% <ø> (ø)

@sbillinge sbillinge merged commit 9bd388d into diffpy:main Dec 21, 2024
5 checks passed
@bobleesj bobleesj deleted the pytest-wavelength-warnings branch December 21, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants