-
Notifications
You must be signed in to change notification settings - Fork 21
docs: add docstrings for on_d, on_q, on_tth, and dump #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
**Added:** | ||
|
||
* docstrings for `on_q`, `on_tth`, `on_d`, and `dump` in `diffraction_objects.py`. | ||
|
||
**Changed:** | ||
|
||
* <news item> | ||
|
||
**Deprecated:** | ||
|
||
* <news item> | ||
|
||
**Removed:** | ||
|
||
* <news item> | ||
|
||
**Fixed:** | ||
|
||
* <news item> | ||
|
||
**Security:** | ||
|
||
* <news item> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -418,12 +418,33 @@ def _get_original_array(self): | |
return self.on_d(), "d" | ||
|
||
def on_q(self): | ||
"""Return the tuple of two 1D numpy arrays containing q and y data. | ||
|
||
Returns | ||
------- | ||
(xarray, yarray) : tuple of ndarray | ||
The tuple containing two 1D numpy arrays with q and y data | ||
""" | ||
return [self.all_arrays[:, 1], self.all_arrays[:, 0]] | ||
|
||
def on_tth(self): | ||
"""Return the tuple of two 1D numpy arrays containing tth and y data. | ||
|
||
Returns | ||
------- | ||
(xarray, yarray) : tuple of ndarray | ||
The tuple containing two 1D numpy arrays with tth and y data | ||
""" | ||
return [self.all_arrays[:, 2], self.all_arrays[:, 0]] | ||
|
||
def on_d(self): | ||
"""Return the tuple of two 1D numpy arrays containing d and y data. | ||
|
||
Returns | ||
------- | ||
(xarray, yarray) : tuple of ndarray | ||
The tuple containing two 1D numpy arrays with d and y data | ||
""" | ||
return [self.all_arrays[:, 3], self.all_arrays[:, 0]] | ||
|
||
def scale_to(self, target_diff_object, q=None, tth=None, d=None, offset=None): | ||
|
@@ -507,6 +528,16 @@ def on_xtype(self, xtype): | |
raise ValueError(_xtype_wmsg(xtype)) | ||
|
||
def dump(self, filepath, xtype=None): | ||
"""Dump the xarray and yarray of the diffraction object to a two-column | ||
file, with the associated information included in the header. | ||
|
||
Parameters | ||
---------- | ||
filepath : str | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. non programmers may not know that that the path includes the filename. Best here is to give an example. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sbillinge added in the new commit. please review |
||
The filepath where the diffraction object will be dumped | ||
xtype : str, optional, default is q | ||
The type of quantity for the independent variable chosen from {*XQUANTITIES, } | ||
""" | ||
if xtype is None: | ||
xtype = "q" | ||
if xtype in QQUANTITIES: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change
xarray
toq-array
to be explicit. And also below, xarray->tth-array
and so on. Just to make it really clear.