Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove margin on typography components in Figma #2490

Closed
Tracked by #2491
Febakke opened this issue Sep 23, 2024 · 1 comment
Closed
Tracked by #2491

Remove margin on typography components in Figma #2490

Febakke opened this issue Sep 23, 2024 · 1 comment
Assignees
@mrosvik
Labels
🎨 figma Everything related to changes in Figma
Milestone
V1 - Lansering

Comments

@Febakke
Copy link
Member

Febakke commented Sep 23, 2024 •
edited
Loading

Remove all margins from our typography components. This is a breaking change, we should check what happens to text elements that use margin=true. If they loose their texts we should consider swapping out our typography components.
@Febakke Febakke converted this from a draft issue Sep 23, 2024
@mimarz mimarz mentioned this issue Sep 23, 2024
Closed
@mimarz mimarz added the 🎨 figma Everything related to changes in Figma label Sep 23, 2024
@mimarz mimarz added this to the V1 - Helhetlig komponentbibliotek milestone Sep 24, 2024
@mimarz
Copy link
Collaborator

mimarz commented Oct 15, 2024

Whats the status on this? @Febakke

@mrosvik mrosvik self-assigned this Oct 18, 2024
@mrosvik mrosvik closed this as completed Nov 1, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Nov 1, 2024
@mrosvik mrosvik modified the milestones: Helhetlig komponentbibliotek, V1 - Lansering Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrosvik mrosvik

Labels
🎨 figma Everything related to changes in Figma
Projects
Team Design System
Status: ✅ Done
Milestone
V1 - Lansering
Development

No branches or pull requests
3 participants
@mimarz @mrosvik @Febakke