Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spacing as property from our Typography components #2491

Closed
5 tasks done
mimarz opened this issue Sep 23, 2024 · 1 comment
Closed
5 tasks done

Remove spacing as property from our Typography components #2491

mimarz opened this issue Sep 23, 2024 · 1 comment
Assignees
@Barsnes @Febakke
Labels
☂️ epic Issues ready 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react
Milestone
Helhetlig tematis...

Comments

@mimarz
Copy link
Collaborator

mimarz commented Sep 23, 2024 •
edited by Barsnes
Loading

This is a summary of meeting held on Typography components and our spacing property.

We will remove the spacing property as its up to the individual organisations to decide how spacing between their typography elements.

We will create an article on recommended typography use with spacing between the individual types.

A helper component to achieve the same result was proposed for a later date #2492

See discussion in #2295 (comment) regarding margin

Tasks
Preview Give feedback
  1. Remove margin on typography components in Figma #2490
    🎨 figma
    mrosvik
  2. Article on best practices for typography #2524
    documentation/guidelines
    mrosvik
@mimarz mimarz converted this from a draft issue Sep 23, 2024
@mimarz mimarz added 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react ☂️ epic Issues ready labels Sep 23, 2024
@mimarz mimarz added this to the V1 - Helhetlig tematisering milestone Sep 23, 2024
@mimarz mimarz moved this from 🔵 Inbox to ☂ Epics in Team Design System Sep 23, 2024
@Barsnes Barsnes mentioned this issue Sep 27, 2024
Merged
Barsnes added a commit that referenced this issue Sep 30, 2024
@Barsnes
feat: remove spacing on typography (#2531)
a11b2b7 
part of #2491
@mrosvik
Copy link
Member

mrosvik commented Nov 4, 2024

All issues done

@mrosvik mrosvik closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from ☂ Todo Epics to ✅ Done in Team Design System Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Barsnes Barsnes

@Febakke Febakke

Labels
☂️ epic Issues ready 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
Helhetlig tematisering
Development

No branches or pull requests
4 participants
@mimarz @mrosvik @Barsnes @Febakke