-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify our form input designs #2561
Comments
Investigate: Should we have hover state on input components? #2632 |
Simplifications for our input components: Skip using hover:
Skip changing border-width on invalid:
Switch colors?
Switch height?
Switch readonly:
|
- Resolves #2553 - Resolves #2587 - Part of #2311 - Make standalone `<Input>` - Adds support for `type="radio"` and `type="checkbox"` - Adds support for `role="switch"` - Documentation for standalone components should be discussed with the team (#2566) and not solved in this PR - Some changes might occur later after #2561, but I suggest we merge this first to be able to move forward
We have decided to follow standard behavior for input elements in V1. We will allow the discussion to continue to see if we gain further insights into which types of users might find hover either a disadvantage or an advantage, and if it does benefit some users, what they consider a good hover state for input elements. Discussion: #2632 |
We decided on daily today to also skip changing border-width on invalid ✅ |
Closing this as switch questions is moved to #2664 |
All
inputs
will soon be one component with different types in code. For examppleinput type=text
. This means they will all use the same component tokens in code. To day we are handling states different on different components. Can we make them simpler and more alike?The text was updated successfully, but these errors were encountered: