Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Table): remove hover on zebra colored row #2291

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Aug 20, 2024

table with zebra enabled made zebra colored rows white on hover. Removed this.
This does not need a changeset, since the changes to table has not been pushed to next yet

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 71cf3f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 20, 2024

Preview deployments for this pull request:

📖 Storybook 20. Aug 2024 - 10:31 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review August 20, 2024 12:35
@mimarz
Copy link
Collaborator

mimarz commented Aug 20, 2024

table with zebra enabled made zebra colored rows white on hover. Removed this. This does not need a changeset, since the changes to table has not been pushed to next yet

Its removed in comparison to main so shouldn't it be a changeset then?

@Barsnes
Copy link
Member Author

Barsnes commented Aug 20, 2024

table with zebra enabled made zebra colored rows white on hover. Removed this. This does not need a changeset, since the changes to table has not been pushed to next yet

Its removed in comparison to main so shouldn't it be a changeset then?

no, this was an expected change in a past PR (#2285) about removing hover on table. This had a changeset in that PR

@mimarz
Copy link
Collaborator

mimarz commented Aug 20, 2024

table with zebra enabled made zebra colored rows white on hover. Removed this. This does not need a changeset, since the changes to table has not been pushed to next yet

Its removed in comparison to main so shouldn't it be a changeset then?

no, this was an expected change in a past PR (#2285) about removing hover on table. This had a changeset in that PR

ah, this was missed when we removed hover?

@Barsnes
Copy link
Member Author

Barsnes commented Aug 20, 2024

table with zebra enabled made zebra colored rows white on hover. Removed this. This does not need a changeset, since the changes to table has not been pushed to next yet

Its removed in comparison to main so shouldn't it be a changeset then?

no, this was an expected change in a past PR (#2285) about removing hover on table. This had a changeset in that PR

ah, this was missed when we removed hover?

yes, this is a fix for this, Would have made a changeset if we had released a next version in between this and that PR :)

@Barsnes Barsnes merged commit f31689b into next Aug 20, 2024
6 checks passed
@Barsnes Barsnes deleted the style/table-zebra branch August 20, 2024 13:04
mimarz pushed a commit that referenced this pull request Feb 21, 2025
table with zebra enabled made zebra colored rows white on hover. Removed
this.
This does not need a changeset, since the changes to table has not been
pushed to next yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants