-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run axe-playwright a11y tests using test-storybook #2400
Conversation
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
79bdc51
to
e4186e9
Compare
Feedback necessary@mimarz I don't feel like the Suggestion: I think the Storybook tests should be run after unit tests, which happen in For the storybook tests to function reliably, we would need to change the workflow config in pull_request:
paths:
- 'packages/**'
- 'apps/storybook/** Is that okay? |
Jepp. It could probably be renamed to a "Test" action as the checks changed a bit after we moved to biomejs. |
baae872
to
489d9d0
Compare
This is just a placeholder workflow, the actual contents of the workflow will be populated in #2400. But [the workflow dispatch GUI](https://github.com/digdir/designsystemet/actions/workflows/test-reports.yml) (and `gh workflow run` CLI) only works if the workflow file is already present on the default branch.
3cbdd7b
to
73fa181
Compare
7f60bd8
to
f9b9ec2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Interesting to see how this testing will go :D
Fixes Axe a11y tests reporting insufficient contrast on the description text when the Switch is disabled
…d false positive in a11y contrast test
…ooltip fade in Fixes false positive color-contrast violation due to axe checking the contrast while the tooltip was not fully faded in yet
591976e
to
44e698b
Compare
ci: enable Biome's "noSvgWithoutTitle" rule, with some exceptions
fix(storybook): delay Storybook tests in Tooltip/DefaultOpen to let tooltip fade in
Fixes false positive color-contrast violation due to axe checking the contrast while the tooltip was not fully faded in yet
refactor(css): animate skeleton background instead of opacity to avoid false positive in a11y contrast test
fix(storybook): disable a11y tests for size/alignment testing stories
fix(react): set Switch wrapper to aria-disabled when disabled=true
Fixes Axe a11y tests reporting insufficient contrast on the description text when the Switch is disabled
fix(storybook): axe violation svg-img-alt in Tabs
fix(storybook): axe violation svg-img-alt in ToggleGroup
fix(storybook): axe violation aria-allowed-role in Alert
fix(storybook): axe violations svg-img-alt & button-name in Badge
fix(storybook): axe violations svg-img-alt & button-name in Button
fix(storybook): axe violations empty-table-header & label in Table
fix(storybook): axe violation scrollable-region-focusable in Table
fix(storybook): axe violation label in Combobox
fix(storybook): axe violation select-name in Showcase
build: make Biome ignore coverage dir by reading .gitignore
ci: add test report publishing also for unit tests
ci: move test coverage report into test.yml to avoid testing twice
test: run axe-playwright a11y tests using test-storybook
Closes #2384
Closes #2452