fix(Heading+Label+ValidationMessage): clean up css styles #2677
Conversation
|
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File CoverageNo changed files found. |
| &[data-size='sm'] { | ||
| @composes ds-heading-text--2xs from './base/base.css'; | ||
| font-size: var(--ds-heading-2xs-font-size); | ||
| } | ||
|
|
||
| &[data-size='md'] { | ||
| @composes ds-heading-text--sm from './base/base.css'; | ||
| font-size: var(--ds-heading-sm-font-size); | ||
| } | ||
|
|
||
| &[data-size='lg'] { | ||
| @composes ds-heading-text--md from './base/base.css'; | ||
| font-size: var(--ds-heading-md-font-size); | ||
| } |
There was a problem hiding this comment.
Don't we need letter-spacing and font-weight here?
There was a problem hiding this comment.
Thats implying the Avatar initials should have the Heading styling as well, but design was not sure about this - font sizes was mostly used to scale with the shape. Lasse and I want to include Øyvind on this one, so it is in the todo list for #2665, but most likely we'll disconnect from heading sizes completely and rather use container query to scale font to match size :)
There was a problem hiding this comment.
Sure, but I think we should set something for those here, otherwise it will inherit and avatars may look different depending on where you put it.
There was a problem hiding this comment.
Thats intentional; if letter-spacing is scaled up on body-text, this should be inherited as this is probably done as an adjustment to the currently used font. font-weight is set on line 15 in avatar.css and line-height is redundant as we are using display: flex and initials will always be single line :)
eirikbacker
deleted the
fix/simplify-heading-label-validationmessage-css
branch
commit ce23f32 Author: Eirik Backer <eirik.backer@gmail.com> Date: Mon Oct 28 10:31:21 2024 +0100 fix(Chip): use input component (#2683) - Fixes #2669 - Fixes wrong height implemented (now correctly `32px`) - Implements simplified states after dialogue with Marianne - Fixes better alignment of label vs. radio/checkbox - Implements logic so elements with the `ds-focus--visible` class automatically hides focus ring on children (no need for confusing, nested focus rings) commit d5e0ba1 Author: Lasse Febakke Straum <33222679+Febakke@users.noreply.github.com> Date: Fri Oct 25 15:08:14 2024 +0200 refactor(tokens): changed spacing and sizing type to dimension (#2688) Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no> Co-authored-by: Michael Marszalek <mimarz@gmail.com> commit 6c1f99d Author: Eirik Backer <eirik.backer@gmail.com> Date: Fri Oct 25 13:52:51 2024 +0200 chore: remove tmp field styling in testing story (#2687) - Since field styling is now merged, `testing.stories.tsx` no longer needs to fake it commit f4f76d3 Author: Eirik Backer <eirik.backer@gmail.com> Date: Fri Oct 25 13:41:36 2024 +0200 fix(Heading+Label+ValidationMessage): clean up css styles (#2677) Figma task is added as #2676 commit d2fc6b9 Author: Tobias Barsnes <tobias.barsnes@digdir.no> Date: Fri Oct 25 13:16:17 2024 +0200 feat: rename `size` prop to `data-size` (#2680) resolves #2673 commit acef771 Author: Eirik Backer <eirik.backer@gmail.com> Date: Fri Oct 25 10:24:19 2024 +0200 fix(Input): inherit line-height (#2685) As pointed out by hawk-eye @mimarz 💪 🙏 🦅 https://designsystemet.slack.com/archives/C07K7NEKXEW/p1729843841118129 commit d3c58b0 Author: Eirik Backer <eirik.backer@gmail.com> Date: Fri Oct 25 10:04:16 2024 +0200 fix(Spinner): use forwardRef and aria-label for consistency (#2682) - Use `aria-label` for accessible spinner label to be consistent with other components - Use `forwardRef` on Spinner --------- Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no> commit 326671a Author: Une Sofie Kinn Ekroll <une.kinn.ekroll@bekk.no> Date: Fri Oct 25 08:26:49 2024 +0200 feat(tokens): add modes for semantic color categories main & support (#2643) Co-authored-by: Lasse Febakke Straum <33222679+Febakke@users.noreply.github.com> commit 7520547 Author: Eirik Backer <eirik.backer@gmail.com> Date: Thu Oct 24 14:19:33 2024 +0200 fix(Radio+Checkbox): use input component (#2607) - Part of #2311 - Fieldset at compound components moved to task #2666 - Fixes #2459 commit f96289a Author: Tobias Barsnes <tobias.barsnes@digdir.no> Date: Thu Oct 24 11:17:42 2024 +0200 chore: enable `noUnusedImports` biome rule (#2675) enables https://biomejs.dev/linter/rules/no-unused-imports/ commit a452813 Author: Une Sofie Kinn Ekroll <une.kinn.ekroll@bekk.no> Date: Thu Oct 24 10:38:59 2024 +0200 feat(cli,theme): don't output underlying primitives for semantic color variables (#2641)
Figma task is added as #2676